search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
853 stars 74 forks source link

use top most layer to avoid group confusion #3590

Closed pineapplespatula closed 8 years ago

pineapplespatula commented 8 years ago

It seems like in some cases our number of selected layers is different than expected when groups are selected. Using the top layer instead should resolve that issue.

fix for issue #3267

iwehrman commented 8 years ago

If we have a bug in which having one group selected results in document.layers.selected returning more than that one layer, that is the bug which should be fixed. I am not in support of this change as a workaround for that bug, at least not without additional information.

pineapplespatula commented 8 years ago

I cant reproduce the bug anymore, i think that using last instead of first is the expect user behavior if we allowed multiple selections. since it would be the top of the layer selection, ( and the first from a user perspective), but you are right that it doesn't address the core issue here of our selection state being incorrect.

TL:DR I think this should be merged eventually, but don't close the bug.

iwehrman commented 8 years ago

@pineapplespatula: I suggest we discuss this in the standup tomorrow.

pineapplespatula commented 8 years ago

Closing until we can actually repro the bug