adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
853 stars 74 forks source link

Setting the position of large artboards is extremely slow #3591

Closed iwehrman closed 8 years ago

iwehrman commented 8 years ago

img

The actual dialog persists for a very, very long time. By the time Photoshop gathers itself minutes later, our bounds are incorrect:

image

iwehrman commented 8 years ago

When modifying the position with the X/Y text inputs in the transform panel it's also slow, but nowhere near as slow as when scrubbing.

iwehrman commented 8 years ago

Here's the log, including a log of played commands: https://gist.github.com/iwehrman/8abd13f451423c2ec1bd

The only Design Space bug I see is that we're wrapping each transform command with unnecessary select commands, but even if that's causing the problem I still blame Photoshop.

iwehrman commented 8 years ago

Here's the log for the comparatively fast case in which we modify the position with the text input: https://gist.github.com/iwehrman/cdfc84e31c1d09304608

It seems like we're using transform when scrubbing and move when using the text input.

ktaki commented 8 years ago

Even a blank artboard document will result in the picture below. Open a new default doc. Select the artboad. Scrub W value to the left and then right.

screen shot 2016-01-25 at 3 50 43 pm

Click on the artboard to force redraw will fix the issue.

iwehrman commented 8 years ago

This also affects swap. It takes minutes to swap artboards on Vermilion.

shaoshing commented 8 years ago

Since we have decided to not ship the scrubby feature in this release, I will make change to remove the related code.

iwehrman commented 8 years ago

:white_check_mark:

chadrolfs commented 8 years ago

Please feel free to assign this bug to me once that PR is merged. There are a handful of other scrubby bugs I'll close as well. :+1:

iwehrman commented 8 years ago

Scrubbies are disabled, back to @chadrolfs.