Closed baaygun closed 8 years ago
I agree that this improves the situation with shift-tab, but it still seems like the tab behavior is not correct here. If the input is focused and I drag the slider, it seems like the input should still be focused. (Or it seems like the slider should have focus.) What do you think?
I think I like the concept of leaving the focus on the already focused input, but not focusing the sliders or the map. I'll see what I can do in this regard, it'll complicate the change. Meanwhile, @iwehrman, please let me know if that sounds reasonable to you.
@iwehrman This is now ready for review, I added some hacky bookkeeping to keep track of last focused component in color picker, and upon mouse up on the sliders or the color map, return the focus back to it.
@placegraphichere it would be nice to get your input on this interaction, you can test it out by checking out this branch.
Hmm, I'm at 4d4de9de30db4ba96daec979348bcc7873f63380 but I'm not seeing the new behavior. I still lose focus entirely after dragging the map slider:
Ugh, disregard that. I have a grunt
problem. Code looks great and, now that I've recompiled, it actually works :grimacing:
Addresses #3281, problem was that we had Tab with no modifiers as a closer, but not shift+tab. And on
Map
focus, it was body that had the focus, so shift tab would be handled by active tool, while tab handled by dialog.Then I realized, we don't allow same key shortcuts, but this was same key / different modifier. So I changed that code to support same key different modifier shortcuts, using modifiers as a way to come up with unique ID.