search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
853 stars 74 forks source link

Padding on formlines first-child removed to fix clipping of color swatch #3602

Closed DivyaPrabhakar closed 8 years ago

DivyaPrabhakar commented 8 years ago

References issue #3549

Before:

After:

One thing to note, is that the padding in other panels changes slightly with this fix. Can @placegraphichere or @designedbyscience give their opinion about the change? I made this image to try and show the slight difference. If this doesn't help, you can just check out toggling the CSS change on this branch.

mcilroyc commented 8 years ago

@placegraphichere for quick design review

placegraphichere commented 8 years ago

I'd like not see the larger panel section headers shown in the new screen shot. It seems like we're adding quite a bit to the bottom of each.

DivyaPrabhakar commented 8 years ago

This is what it looks like now -- thoughts @placegraphichere?

Before:

After:

placegraphichere commented 8 years ago

@DivyaPrabhakar nice

DivyaPrabhakar commented 8 years ago

@mcilroyc If you like it, merge it.

mcilroyc commented 8 years ago

sure!