search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
853 stars 74 forks source link

Tab should autocomplete current match in search #3610

Closed iwehrman closed 8 years ago

iwehrman commented 8 years ago

Currently <Enter> applies the currently selected filter, but <Tab> does nothing. <Tab> should also apply the currently selected filter, if there is one.

DivyaPrabhakar commented 8 years ago

This is also solved in PR #3479 now

DivyaPrabhakar commented 8 years ago

FBNC @iwehrman

iwehrman commented 8 years ago

It does seem like tab does the same thing as enter, which is technically what this bug was about. But, I also notice that tab/enter does not work correctly with filters. For example, if I type "op" then instead of filtering by open documents (the selected option), it just closes. Would you like me to open a different bug for this, @DivyaPrabhakar?

DivyaPrabhakar commented 8 years ago

@iwehrman I read this issue to mean "Tab" should autocomplete the suggestion, and then you have the option of pressing "Enter" or not. For example, if I type "op", the autofill suggestion may be "Open Documents". If I press "Tab" then "Open Documents" changes from the suggestion to my enter search query. Then I can press enter on that option or continue using the arrow keys to navigate the datalist.

1.) Do you think that "Tab" should select the option for you completely? Therefore "Tab" would be equivalent to "Enter"?

2.) I am definitely not seeing the problem where the search dialog just closes after you press "Tab" on a filter.

iwehrman commented 8 years ago

After discussing with @DivyaPrabhakar, I think this issue can be considered fixed, though she may decide to change the behavior of tab later to auto-select the current filter.