adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
853 stars 74 forks source link

Prevent Size and Position components from blinking on mount #3616

Closed iwehrman closed 8 years ago

iwehrman commented 8 years ago

The Size and Position components currently blink when first showing a document. This is entirely due to quirks in their shouldComponentUpdate methods. In particular, it seems like the components weren't rendering until their first state change after mounting.

@volfied: I ended up removing a bunch of code that you wrote recently, so I'd like your feedback on this to make sure I didn't screw something up. I've removed some of your optimizations because I think they were partially responsible for the blinking.

Addresses #3613.