adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
853 stars 74 forks source link

Scan and load actions and stores using webpack contexts #3629

Closed baaygun closed 8 years ago

baaygun commented 8 years ago

Instead of using index.js files for stores and actions, this change uses Webpack contexts to scan the two folders at compile time and dynamically bundle files.

This has the added benefit of not having to maintain index.js files for our actions and stores.

One change that had to happen to achieve this was change action name strings like toolSuperselectType to tool.superselect.type where it's a dot separated path of the file.

shaoshing commented 8 years ago

Hey @volfied that's a very nice use of the WebPack's context feature! I just have a few questions, otherwise, everything looks excellent. Back to you.

baaygun commented 8 years ago

@iwehrman and @shaoshing thank you for your reviews. I've cleaned up the code and am actually using contexts a bit smarter and integrated to flux controller now.

Please re-review.

baaygun commented 8 years ago

@iwehrman right back at ya.

iwehrman commented 8 years ago

LGTM.