Open designedbyscience opened 8 years ago
Sidenote: also tried this morning to animate translate
instead of left
, exists on designedbyscience/panel-animation-update
Feels like there is a slight improvement in framerate, some visual glitches though
Timeline for Retina, use_osr: false
I called this review only mostly because it doesn't perform that well, and we'd need to live with that in master if merged
I'm super happy we're looking at this. That said, I agree with @designedbyscience that this is probably not performant enough (at this point) to be merged.
The appearance panel doesn't animate when collapsing like the other panels.
When the libraries panel collapses down, its contents seem to be hidden before the animation starts, which seems weird:
The same basic thing seems to happen with the export panel, though it collapses up (for some reason):
Closing the last open file flashes pretty badly:
Back into the animation mines!
Updated, however there is an issue with cloaking currently
Updated again, cloaking issues fixed. Pulled some of the logic about panel state and CSS classes into the panel set
To check the animations, you need to add a feature flags object to the manifest.json
with a property use_animations:true
and restart Photoshop
Needs moar rebase :8ball:
It also seems like the document header does not animate when opening a panel; it just gets pushed over in one step, and then the panel position is animated. I guess I'd be OK with merging it anyway if it were off by default, but the animation still seems to be enabled despite a lack of feature_flags
entries in my settings.json file. Any ideas?
1) There was an error that I let some things animate despite the flag (fixed now). This also accounted for the header not animating when the panels did
2) It is the manifest.json
file, not settings.json, where you want to add that feature flag
Back to @iwehrman.
I also have another branch I started to particularly improve the open/close section animation, where I can explicitly animate height rather than fool around with min-height
I've updated a previous branch to work with more recent changes to spaces-design. For now, I will just tag this as Review Only
Below are some timelines for expanding/collapsing the columns with OSR on and off OSR: true Non-Retina![osr_true_non-retina](https://cloud.githubusercontent.com/assets/22372/12728085/2fbdbff0-c8ee-11e5-9afd-c57051c22508.png)
Retina![osr_true_retina](https://cloud.githubusercontent.com/assets/22372/12728092/35f6315e-c8ee-11e5-9387-2c6ef165d33c.png)
OSR: false Non-Retina![osr_false_non-retina](https://cloud.githubusercontent.com/assets/22372/12728103/42f984c8-c8ee-11e5-9f88-9d137a080576.png)
Retina![osr_false_retina](https://cloud.githubusercontent.com/assets/22372/12728109/479cc954-c8ee-11e5-9cd0-d8eacf97f87b.png)