adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
852 stars 74 forks source link

Make grunt tasks check for dependencies #3648

Closed shaoshing closed 8 years ago

shaoshing commented 8 years ago

npm install is required

This PR uses the grunt-check-dependencies package to add the ability to check for package dependencies before running some grunt tasks, and will inform you when npm install is needed. Below are the tasks that will check dependencies:

screen shot 2016-02-01 at 11 43 02 am
baaygun commented 8 years ago

Is this going to work offline? It would suck to block the build progress if there are errors with package checking, can you make it warn only instead?

shaoshing commented 8 years ago

@volfied that's a good question. The package itself does not support silenced warning, but you can use the --force option to ask Grunt to ignore the warnings. Given that we rarely work without internet, I think this is a good enough workaround? Please let me know your thoughts.

baaygun commented 8 years ago

Alright, I'm semi-convinced this helps. We'll see how it goes!