search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
852 stars 74 forks source link

More modal-safe actions #3649

Closed iwehrman closed 8 years ago

iwehrman commented 8 years ago
  1. Mark most actions that do not write PS doc or app state as modal safe. Playing get commands should work even when PS is in a modal state, and the adapter should not require those to be played with the canExecuteWhileModal flag. Small consequence: you can now pan the canvas without ending the modal state.
  2. Make setGroupExpansion and setColorStop modal safe even though they do write PS doc state.
  3. Instrument the controller so that it fails fast if there are duplicate read/write locks, or unexpected action properties, both of which are indicative of typos.
  4. Fix a few typos which caused both of the aforementioned bug instances, and also add a few other missing locks.
baaygun commented 8 years ago

Just one question @iwehrman but rest looks good.

Do we have any plans on warning when transferring from modal safe to non modal safe functions?

baaygun commented 8 years ago

Ok, confusion cleared!