adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
852 stars 74 forks source link

Unify mask commands to all have the same result #3652

Closed pineapplespatula closed 8 years ago

pineapplespatula commented 8 years ago

Adding code to the two paths into vector masks so that they have the same results depending upon the layer selection

iwehrman commented 8 years ago

Does this address a particular bug? Can you say a little more about what you mean about mask commands having the "same result"?

pineapplespatula commented 8 years ago

this is in reference to the first check mark on my JIRA task for vector masks. basically regardless of how you enter mask mode you will get a the correct result based upon how many layers you have selected.

CMD M with 1 layer selected enters mask mode. m or toolbar button with a shape and pixel layer selected creates a vector mask from the shape

the thing that isnt done here is dynamically changing the menu text to reflect the resulting action.

iwehrman commented 8 years ago

Thanks for clarifying. I found some nits. So, back to @pineapplespatula for that.

pineapplespatula commented 8 years ago

addressed nits @iwehrman :repeat: