adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
852 stars 74 forks source link

Undo after deleting an invisible layer restores layer visibility #3660

Open mcilroyc opened 8 years ago

mcilroyc commented 8 years ago

Repro: drag out 3 rects, select one, turn visibility off, then delete, then undo. Result: layer is returned but with visibility on.

This is a spin-off of #1942. The following are comments distilled from that issue...

With the "three rect" repro scenario mentioned above, there is indeed a difference between PS and DS. But interestingly, it has to do (it seems) with where the layer creation/deletion takes place, not the undo. In other words, if I set up the scenario in one system, then regardless of which one I use to "step back", the behavior is consistent between the two. Specifically, if I create, hide, and delete the layers in DS, then when I switch to PS and step back, then the layer becomes restored and visible.

Something about the way we are deleting layers is causing the 'step back' to make-visible the undeleted layer. As I mentioned above, it is possible to repro this 'step back' behavior in Classic PS if you do so on a layer that was deleted in DS.

mcilroyc commented 8 years ago

core: PS-1226