Closed shaoshing closed 8 years ago
:moneybag:
One concern with this is that the rest of the panel contents fade in when they're ready, but the Libraries panel now does not, and it feels just a little off. Can you do some experiments to try to improve this? Like, try fading in the libraries panel content when it's ready?
Or, alternatively, rendering a spinner when first showing the UI and replacing that spinner with the contents when ready?
Good idea. I will experiment with the spinner loader if content is not ready
Sorry, I started reading through this and then got distracted, but besides my one gripe I think this looks great. I'm ready to merge if we can improve the loading experience just a little bit.
@iwehrman I experimented and compared the fade-in
and spinner
solutions, and I think face-in
has better user experience in this case. The libraries panel usually can finish loading and rendering within within 500ms (even for large collection, like Samples Collection April 23 2015
, the time is still within 1200ms range). In such short amount of time, the spinner
seems to be distracting. Also, it makes me feel that the panel is slower, compare to fading-in the content when ready. The reason might be because moving object can attract attension easier.
I've push my changes with the fade-in solution, please try it out and let me know what you feel.
I'm not surprised that the spinner was distracting, but I'm glad you tried both options. I think the current behavior is great. I'm ready to merge except for that one additional typo. :+1: :+1:
@iwehrman I just addressed the typo. Please review again.
LGTM!
Thanks for merging!
This PR includes the following optimizations on CC Libraries to improve performance.
beforeStartup
callback, which slows down the startup process and triggers libraries panel rendering, which slow down the startup further. This process can be deferred as the chance of using the librarise panel right after startup is small.Below is the result of the before/after test in various scenarios:
(selected library:
Samples Collection April 23 2015
)