search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
851 stars 74 forks source link

Refactor debugging menu items #3697

Closed shaoshing closed 8 years ago

shaoshing commented 8 years ago

This PR makes the following change to the debugging menu items:

Moves all debugging menu items to a new top-level menu Debug
screen shot 2016-02-09 at 9 56 21 am
Addes new debugging items:

1 Load Debugging Helpers

debug-2

2 Log Descriptor Events: Log descriptor events. includes events sent by PS and DS. This option is togglable.

debug-1

3 Log Highlights Events (togglable): Log Highlights tracking events. This option is togglable.

debug-3

iwehrman commented 8 years ago

Looking good! Back to @shaoshing for a little more earth-moving.

shaoshing commented 8 years ago

Hi @iwehrman I've updated the PR to address your comments. The highlight are as follows:

Back to you to review again. Thank you.

shaoshing commented 8 years ago

Hi @iwehrman, I addressed the transfer naming issue and exclude the debug module in production mode. Back to you.

shaoshing commented 8 years ago

the new change are tested/passed in dev and production mode.

iwehrman commented 8 years ago

Fantastic, thanks!