search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
851 stars 74 forks source link

Up/down arrow keys skip a line in the search dialog #3707

Closed ktaki closed 8 years ago

ktaki commented 8 years ago

Traversing search dialog with up and down arrow keys skips a line.

screen recording 2016-02-12 at 03 59 pm

ktaki commented 8 years ago

Apparently, this is Mac only.

iwehrman commented 8 years ago

I'm guessing this has to do with @jfitz-adobe's recent fix to ensure that keydown events were being correctly emitted on Mac. I believe @DivyaPrabhakar's current work should address this, so tentatively assigning to her.

DivyaPrabhakar commented 8 years ago

I am seeing this too and it occurred after @jfitz-adobe's change, so I agree, I think they are related. The other side effect is that when you type in the search bar and then backspace, it deletes two characters at a time.

iwehrman commented 8 years ago

Actually all keydown events are being duplicated on Mac at least. You can see this by arrowing left/right in a TextInput and watching the cursor move two steps instead of one. This is the result of a recent change by @jfitz-adobe, which has been rolled back by @volfied in CL 1063621. Hence, FBNC to @ktaki.

ktaki commented 8 years ago

Verified the fix.