search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
851 stars 74 forks source link

Fix panel bounds measurement #3708

Closed iwehrman closed 8 years ago

iwehrman commented 8 years ago

The structure of the PanelSet recently changed to include the IconBar, but the bounds arithmetic did not change along with it. This resolves the discrepancy by putting the PanelSet in charge of reporting both panelBounds and iconBounds. As a nice side effect, there is one fewer component calling updatePanelSizes all the time.

Addresses #3703.

shaoshing commented 8 years ago

CC @designedbyscience since he is thinking about separating the IconBar from the panels to accommodate to the panel animations.

iwehrman commented 8 years ago

Issue addressed (not sure why it was working in my branch at all...). Ready for re-review.

iwehrman commented 8 years ago

Unassigning @designedbyscience since he's busy at the moment and I don't think we should wait for that guy.

shaoshing commented 8 years ago

Ok. Let's merge this and @designedbyscience can perform a rebase later.