adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
852 stars 74 forks source link

Export non-artboard doc does nothing #3710

Closed placegraphichere closed 8 years ago

placegraphichere commented 8 years ago

Using the Export panel on a non-artboard document (JPG for example) will allow the Export button to be clicked, a file path chosen, but nothing happens.

iwehrman commented 8 years ago

Is this a known limitation, @mcilroyc? Or is this a bug? I think I vaguely remember discussing this with you, but it's hazy...

mcilroyc commented 8 years ago

well this is two-fer. 1) It is a known limitation but surely solvable. 2) In general, the Export modal window should not allow clicking the export button when there are no configured+selected assets.

This is assigned to the right person. I foresee a batch of export work in the near future.

ktaki commented 8 years ago

@mcilroyc: Have you changed anything in this area? I can open a jpg file, add an asset, and export it as png with current master. Am I missing something here?

chadrolfs commented 8 years ago

Following the steps above (no asset in the export panel in the UI under Effects), opening the Export dialog from File menu or title bar icon, will have no assets in the dialog and you CAN click the Export button at the bottom right of the dialog and select a folder to export but nothing gets exported. According to Cory's comment above, you shouldn't be able to click the Export button.

placegraphichere commented 8 years ago

There is an aspect of "it should just work" to these issues. I'd expect to be able to export at any time. so perhaps we should think about it that we should actually not disable the export modal button, but allow them to get something exported instead.

Artboards auto populate with 1x in the export panel, so perhaps the same logic should be applied to non-artboard docs.

mcilroyc commented 8 years ago

@placegraphichere I agree it should just work. I'm a little worried that the current UI would still be confusing though. Should a "blank" export dialog (with no configured exports) always just magically export a 1x document-level image?
ss

We currently have no real treatment of document-level exports in the modal window. Maybe Adding something (even a simple "export document" checkbox) to make it clear that something will happen when clicking Export. Just spit ballin

iwehrman commented 8 years ago

FBNC to @ktaki.

ktaki commented 8 years ago

Confirmed the disabled Export button. I would complain the button is still as shiny as it was enabled, but I will accept it as a temporary solution.