Closed shaoshing closed 8 years ago
Looks good so far. It's too bad that the simple structure of beforeStartup -> ready -> UI drawn
didn't hold up. I guess as long as the view doesn't try do something as a result of having an initialized document, and assuming that some other store has its other dependent data ready. Because that store may not yet be fully initialized as a result of some other action running it's beforeStartup
method a little later. Still, that's only a theoretical concern, and this seems like a fine way to get the UI drawn faster. :+1:
Back to @shaoshing to address a few minor suggestions.
@iwehrman I've addressed your comments. Also addressed a potential flashing issue in https://github.com/adobe-photoshop/spaces-design/pull/3721/files#diff-6ca92cfb1bbcf69e9825408c732136d7R177. Back to you for a second review.
Looks good, works good!
This PR promote the panel's fade-in animation so that they are displayed faster during startup. Before, the animation starts when the
FluxController
emitsready
event. In general, the event is emitted 150ms - 300ms later after thePanelSet
completes rendering for the active document, as the event has to wait until allbeforeStartpu
callbacks are completed. So, instead of waiting for theready
event, thePanelSet
now starts the animation when its active document's content are flushed to the DOM.Main
component receives theready
event.Improvements