Console/Timeline improvements

adobe-photoshop / spaces-design

Adobe Photoshop Design Space

http://adobe-photoshop.github.io/

Other

851 stars 74 forks source link

Console/Timeline improvements #3727

Closed shaoshing closed 8 years ago

shaoshing commented 8 years ago

This PR includes the following improvements to the Console and Timeline:

Togglable action log

You will be able to disable action log and timestamp completely by turning Log Actions and Log Action Transfers off. This is useful when you need a clean console or Timeline.

Better descriptor log

Descriptor log now shows the params/result in a collapsed group, which avoids overcrowding the console.
Has stack trace
Show completion time. This helps target slow descriptors.
Show timestamp in the Timeline.
Descriptor calls have unique ID to help mapping the executing/finished message in the console, and mapping between the console and timeline.

Startup timestamp

shaoshing commented 8 years ago

@iwehrman I've eliminated the use of global loadTime, and switch to the descriptor call's real ID. Back to you for reviewing.

iwehrman commented 8 years ago

Besides my other comments offline, can we also make action times enabled by default (in debug builds)? This is just to reduce confusion in the short term.

iwehrman commented 8 years ago

Also, it doesn't seem like the traces in the descriptor "finished" messages are ever very interesting. But maybe I've just been missing the interesting cases.

iwehrman commented 8 years ago

Also, it might be possible to format these messages a little differently to make it easier to match up the calls. For example, instead of:

[Descriptor] Executing get - 1544
[Descriptor] Finished get in 21ms - 1544

it might help to align the IDs and stick the time at the end:

[Descriptor] Executing get - 1544
[Descriptor] Finished get - 1544 in 21ms

And, as mentioned offline, red highlighting for long calls would be awesome :)

shaoshing commented 8 years ago

@iwehrman below is the updated version

highlight slow descriptor (> 100ms)
remove trace for the finished log
move time to the end
show summarized commands for batchPlay
Enable Log Actions by default

screen shot 2016-02-19 at 12 46 37 pm

shaoshing commented 8 years ago

Fixed the repeated in in the message

iwehrman commented 8 years ago

Well, this is great. Two more micro nits and then I'll merge.

shaoshing commented 8 years ago

Nits addressed! Back to you @iwehrman

iwehrman commented 8 years ago

Super cool!