search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
851 stars 74 forks source link

Only update overlays when pointer is inside canvas bounds #3733

Closed iwehrman closed 8 years ago

iwehrman commented 8 years ago

What it says! This cuts down on some pointless, wasteful calls to hitTest.

Addresses #3732.

baaygun commented 8 years ago

This only works for top and left areas of the window. I mean, it's still better than calling it all the time, but we should instead check with panel store to avoid making calls when mouse pointer is out of the visible canvas.

iwehrman commented 8 years ago

Derp. I'll try again.

iwehrman commented 8 years ago

OK! Now I'm checking against the canvas bounds from the panel store. And on all four sides! :sweat_smile:

iwehrman commented 8 years ago

But, really, who even moves their mouse that far to the right anyway?

shaoshing commented 8 years ago

Verified all four sides. Thanks for fixing!