Changes to search bar: edits the tool names, direct selection vector option conditional

adobe-photoshop / spaces-design

Adobe Photoshop Design Space

http://adobe-photoshop.github.io/

Other

852 stars 74 forks source link

Changes to search bar: edits the tool names, direct selection vector option conditional #3749

Closed DivyaPrabhakar closed 8 years ago

DivyaPrabhakar commented 8 years ago

References issue #3737

All tools have "Tool" succeeding their individual names
"Super Select" --> "Select Tool"
"Vector Mask" --> "Vector Mask Mode"
"Super Select Vector" --> "Direct Selection Tool"
"Direct Selection Tool" is not an option in Search > Global Shortcuts if we are not in Vector Mode

iwehrman commented 8 years ago

This line is the problematic one: https://github.com/adobe-photoshop/spaces-design/blob/0635b17017c3fa7ebde207d7916be285f6d15d1d/src/js/actions/tools.js#L977

Instead of using this tool name (which can and should be completely eliminated from our code), we should be using localized strings that are keyed by tool ID. This might necessitate a new section in our strings.js dictionary specifically for these entries.

DivyaPrabhakar commented 8 years ago

@iwehrman We talked about your comment regarding tool.name -- let me know if my changes address your concern.

DivyaPrabhakar commented 8 years ago

@iwehrman Back to you with the changes and one question

iwehrman commented 8 years ago

Works good, looks great. Here we go!