Scroll layers panel when layer is invisible due to change of position

adobe-photoshop / spaces-design

Adobe Photoshop Design Space

http://adobe-photoshop.github.io/

Other

848 stars 81 forks source link

Scroll layers panel when layer is invisible due to change of position #3755

Closed shaoshing closed 8 years ago

shaoshing commented 8 years ago

Fix for issue #3375

I have to move the scroll-into-view logic into the LayerGroup as ordering LayerFace within the same group will not re-render the layer face, which makes it difficult to know when to scroll the panel as the LayerFace#componentDidUpdate is not called. This also result in a cleaner solution for scrolling the panel. Now the scroll works for:

order layer via menu items (e.g. Bring Forward cmd+])
undo/redo layer order

iwehrman commented 8 years ago

Seems fine, just one question, which may or may not be silly.

shaoshing commented 8 years ago

@iwehrman I've replaced the querySelector with React component API, which looks more elegant now :D Back to you.

iwehrman commented 8 years ago

Lovin' it :hamburger: :fries: