Closed iwehrman closed 8 years ago
Ideally someone would test this in all for supported languages.
The code looks good to me. @ktaki or @chadrolfs can you run this in each language especially for the spacing changes added?
Will try it after lunch.
@iwehrman: Now I see the translation. It, however, produces the following error when locale was set to en_GB
GET file:///Users/ktaki/PSbuilds/playground-dev/1367/photoshop-Release_x86_64/A…015.5.app/Contents/Required/Plug-Ins/Spaces/www/src/spaces-design-en-GB.js net::ERR_FILE_NOT_FOUND
@ktaki @pineapplespatula: I made a change to how the language-specific JS files are loaded which I think will address this issue. Can you please re-test?
I can confirm that this works for me in en-GB
mode.
Yes, it is working now.
Oops. It looks like you can switch to DS with non-supported languages.
That is a core issue. CC @dtristram @jsbache
Do you need a separate bug for it?
Yes please! Assign to @dtristram.
https://jira.corp.adobe.com/browse/PS-2771 for the non-supported locales issue. I think you can merge this PR now.
Unfortunately the layout is still incorrect on Japanese with font-size: 62.5%
(i.e., on a retina iMac).
I think the PR should still be merged. I'll try to take a look at the layout issue tomorrow.
OK, I pushed another commit that does two things:
I haven't touched the titles, so they're still incorrectly centered. But I think this is the last fix I'd like to do in this particular PR.
Please re-review @pineapplespatula and re-test @ktaki.
I lied, now there's another commit that falls back to English if the system language is something other than English, French, German or Japanese.
I've tested in English, English (UK), French (North African), German, Japanese, and Spanish (Mexico).
Now it shows English UI for locales other than EFGJ.
Only glitch is both Chinese locals (zh_CN, zh_TW) show huge dialog frame for the intro.
the code looks good to me. we can worry about localization issues after UIF
{ADOBE_XD}
separator in the Japanese translation that causedundefined
to trickle into the last slide.Addresses #3819 and partially addresses #3820.