search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
848 stars 81 forks source link

Updated by ALF automation. #3822

Closed fzhu1978 closed 8 years ago

fzhu1978 commented 8 years ago

@iwehrman Please help to merge latest localization changes.

baaygun commented 8 years ago

I've reviewed this in Ian's absence. If we merge this in right now it will break the build again since our localization does not merge arrays correctly. As far as the other changes go, only change I could see was in Japanese there is a space between ADOBE_ and XD.

fzhu1978 commented 8 years ago

@volfied Thanks, I remember the fix. But it will bring trouble is there are new strings to translated. Is it possible to keep structure as same as English?

iwehrman commented 8 years ago

@fzhu1978: would you mind re-applying the translations against the latest dictionaries? We aren't planning to add any new strings at this point, and merging this as-is would revive some fixed bugs.

baaygun commented 8 years ago

@fzhu1978 Besides the transformation, I see no changes in any of the strings with this PR. Is this intended? Only difference I see is ADOBE_XD has become ADOBE_ XD. Please confirm.

fzhu1978 commented 8 years ago

@Ian, to get the translation back, I will keep ALF running, it will add new changes to this pull request but please omit it. I will manually update localization and create PL after all are translated (two go URL).

The broken string for ja_JP will be in the new PL as well.

iwehrman commented 8 years ago

@fzhu1978 Great! Just let me know when this PR is ready for re-review.

fzhu1978 commented 8 years ago

Translation of goURL came back, I will close it and create new clean PL.