Open nimbupani opened 9 years ago
@nimbupani Followup question: What ids this combination should create? Note that name “Rounded Rectangle 1” was given automatically by Ps.
Also, we actually don't use ids anymore as far as I can tell. @DmitryBaranovskiy am I mistaken?
Question is if and when we should use ids. @nimbupani could you try to figure this out?
We don’t want to put ids on every element unless user wants to. As I can see it, the problem is that we can’t distinguish if layer name was default or actually given by a user.
So, after this commit, previous layers will have following ids: • “Fleur-de-lis” • “circle” • “circle-2” • none • “🎈”
Hey sorry for the late follow-up.
In my specific use-case, I have around 200 icons I need to export as SVGs. These icons are all extremely similar and follow the same Icon and BG layers. In my CSS, I want to set up a class for an Icon, and a class for a BG layer so I can control every icon button in my website from the same stylesheet.
This SVG code is going to be embedded inline in the HTML so that different states can be achieved by using javascript to change CSS properties. For example, A disabled button is just the default BG color, with the icon layer opacity set to 0.4.
What I currently have to do:
I can then interact with this in the DOM for state changes, such as hover, selected, active, in focus, disabled etc.
I hope this helps in some way!
A user (Tom Gantzer) requests using layer names to start IDs in SVG paths. Here is an example:
More reasons why: