search

adobe-research / theseus

A pretty darn cool JavaScript debugger for Brackets
Other
1.34k stars 69 forks source link

Visual tweak, first pass. #23

Closed larz0 closed 11 years ago

larz0 commented 11 years ago

@alltom @joelrbrandt here's the first pass. Let me know what you think.

joelrbrandt commented 11 years ago

photo sep 05 11 52 57 pm

joelrbrandt commented 11 years ago

@larz0 this is fantastic! @alltom is a much better person than me to evaluate whether this will break anything. Just a heads up that @alltom is very busy with a deadline on Sept 18, so he may be a little slower to respond than usual.

larz0 commented 11 years ago

@joelrbrandt Yep no problem. Thanks for the heads up~

image

alltom commented 11 years ago

Always showing the scroll bar was in response to people frequently not realizing that there was more content in the log, then missing important information or becoming confused as a result. Unless you have suggestions for fixing that, I think I'm going to bring that back.

However, everything else looks great! Thanks a ton!

larz0 commented 11 years ago

Thanks @alltom. Not sure if the scrollbar issue is related to Windows because I'm only on OS X; I removed the scrollbar to make it more consistent with the other bottom panels.

alltom commented 11 years ago

AFAIK Windows always shows scroll bars, so there's no usability problem there. I think the scroll bars are only hidden when everything fits on the screen, or you're on OS X with only trackpads (as opposed to mice with scroll wheels) connected.

I value being consistent with the rest of Brackets, but this convention seems to cause trouble with OS X users who haven't picked up the habit of pawing at every window all the time.

larz0 commented 11 years ago

Ok cool. "Always show scroll bar" can be turned on in OS X preferences but it feels a little out of scope.