search

adobe-research / theseus

A pretty darn cool JavaScript debugger for Brackets
Other
1.34k stars 69 forks source link

German translation #25

Closed marcelgerber closed 10 years ago

marcelgerber commented 10 years ago

Are you interested in a german translation? I'm from germany and your extensions is great (brackets, too), so I could translate the extension into the german language.

But you may should add more translations into the scr/nls-files, so more words would be translated...

alltom commented 10 years ago

I'd love that. Have you done software translations before? I copied the internationalization file structure from Brackets into Theseus so that it would be possible to add translations, but I've never tried doing so.

If you know what you're doing, you can just get to it and I'll merge. If not, let me know, and I'll poke around to figure out how internationalization works.

marcelgerber commented 10 years ago

I've changed a little bit within the brackets-translations, so I think that's no problem.

marcelgerber commented 10 years ago

See this: https://github.com/SAPlayer/theseus/blob/master/src/nls/de/strings.js

marcelgerber commented 10 years ago

Yes, it works! image Unfortunately many things are still english...

Just edited https://github.com/saplayer/theseus/blob/master/src/nls/strings.js to get this to work.

alltom commented 10 years ago

Awesome! I'll merge that, and I'll also try to move the rest of the app's strings into the internationalization file. Thank you!

alltom commented 10 years ago

Weird, my photo is supposed to be on that screen. I wonder if that's a Windows issue.

marcelgerber commented 10 years ago

Yes, I wondered too, but it isn't there (it wasn't there before, too).

marcelgerber commented 10 years ago

Okay, I think I've found the problem: The URL of the pic is invalid:

<img src="file://file:///C:/Users/Marcel/AppData/Roaming/Brackets/extensions/user/theseus/src/tom.jpg" width="48" height="48" align="right">

https://github.com/adobe-research/theseus/blob/master/src/Invitation.js#L44

Responsible for this:

// On Windows, $.get() fails if the url is a full pathname. To work around this, // prepend "file:///". On the Mac, $.get() works fine if the url is a full pathname, // but doesn't work if it is prepended with "file://". Go figure. // However, the prefix "file://localhost" does work.

https://github.com/adobe/brackets/blob/master/src/utils/ExtensionUtils.js#L133

alltom commented 10 years ago

Thanks, SAPlayer! I just merged your translation. Thanks a ton for that. I'll get to the Windows image pull request in a bit. :)