search

adobe-research / theseus

A pretty darn cool JavaScript debugger for Brackets
Other
1.34k stars 69 forks source link

Theseus is causing New Button in Brackets inline editor not to function correctly. #48

Closed RaymondLim closed 10 years ago

RaymondLim commented 10 years ago

Clicking on new rule button while in the CSS Quick edit, opens and closes the list of stylesheets instantly.

https://github.com/adobe/brackets/issues/6641

alltom commented 10 years ago

Looking into it now, thank you!

alltom commented 10 years ago

Ah, I was able to reproduce:

  1. Install Brackets Sprint 36 and Theseus.
  2. Create an HTML file and 2 CSS files.
  3. Start Live Development.
  4. Open Quick Edit on an HTML tag to see the associated CSS rules.
  5. Click the "New Rule" button. Since there are multiple CSS files, this should open a menu so you can select which file you want to create the rule in.

Expected: the menu appears and you can select a file name.

Actual: the menu appears momentarily, but disappears.

If Live Development is not started, the menu works as expected. If Theseus is disabled, the menu works as expected. If Theseus is enabled, but there is no JavaScript on the page, the menu works as expected.

My guess, from the rapidity with which the menu disappears, my guess is that something Theseus does in its update timer causes the menu to lose focus.

alltom commented 10 years ago

Ah, I guess it's triggering a resize event? Maybe it's that the call count being modified is changing the size of the editor. Hmm.

alltom commented 10 years ago

I just released Theseus 0.4.9 which is the same as 0.4.8, but should fix this issue.

RaymondLim commented 10 years ago

Thanks for taking care of it right away!