redirect request from brackets live development for public dir files to ...

adobe-research / theseus

A pretty darn cool JavaScript debugger for Brackets

Other

1.34k stars 69 forks source link

redirect request from brackets live development for public dir files to ... #52

Closed benchuk closed 10 years ago

benchuk commented 10 years ago

Hi first pull request :) This path fixes the problem where one starts live development and get the url set to http://...../public/index.html - where node does not allow this. This happen because live dev does not know about node being attached. There for redirection fixes this issue.

alltom commented 10 years ago

Thanks for the patch! This is something that's bugged me for a while, but I usually got around it by adding a redirect to the app. Your patch is probably how it should work. :)

There are just 2 things I think need to be fixed before I can merge this:

[x] Change the indentation back to 2 spaces (it was really hard to tell what you'd actually changed)
[x] Use indexOf directly instead of defining contains

And one thing that would be nice:

[x] Match the style of the rest of the file (spaces around function arguments, space after if, no quotes around object keys, etc)

Thanks so much!

alltom commented 10 years ago

I fixed those issues and merged it as a089c01a21e92a9e1036b52538f470905d07cb18. Thank you!

benchuk commented 10 years ago

Cool thanks :) Sorry- haven't found the time to fix that till now... :)

On Tue, Apr 8, 2014 at 3:59 AM, Tom Lieber notifications@github.com wrote:

I fixed those issues and merged it as a089c01https://github.com/adobe-research/theseus/commit/a089c01a21e92a9e1036b52538f470905d07cb18. Thank you!

Reply to this email directly or view it on GitHubhttps://github.com/adobe-research/theseus/pull/52#issuecomment-39801435 .