Closed buuhuu closed 3 weeks ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
A few suggestions:
blocks/cards/_component.json
to blocks/cards/_cards.json
to be consistent with models/_button.json
component-definition.json
and _component-definition.json
to make it plural: component-definitions.json
and _component-definitions.json
to make it consistent with component-filters
and component models
@jckautzmann
I’d rename blocks/cards/_component.json to blocks/cards/_cards.json to be consistent with models/_button.json
Very good suggestion as this allows
_cards.json
and _card.json
I’d rename component-definition.json and _component-definition.json that would be a breaking change which I would not want to do now. I agree though.
Hi all, Any ETA when this will be merged? I'm about to migrate a project and would like to know if I should wait a little bit, or just move forward with the current approach. Thanks.
This will be merged after the next AEM Cloud Services release scheduled for this / next week.
The majority of changes can be used. Unfortunately I made some changes to the default content models (button, title, image) and rename the fields according to our naming conventions so that they can be used in container blocks without any changes. This change is the only thing that requires the AEM CS release. Spitting/merging the files works today.
valueType
,value
, ...)Each block now has a
_component.json
partial with a json object that containsdefinitions
,models
andfilters
. Each of them is an array as a block may expose 0..n of either of them. The default content model partials are now stored inmodels/
as well as the partials for component-models.json, component-definition.json and component-filters.json. The file name format with the leading_
was inspired by sass partials (files that are meant to be imported into other files).Besides that this commit adds
husky
pre-commit hook support, with a simple hook that merges the models/definition/filters files if any of the partials changed.