adobe-rnd / aem-boilerplate-xwalk

Use this repository template for new AEM XWalk projects.
https://main--aem-boilerplate-xwalk--adobe-rnd.aem.page
Apache License 2.0
23 stars 29 forks source link

Husky pre-commit script silently adds all files and could lead to unexpected contents being committed #43

Closed josephrignanese closed 1 month ago

josephrignanese commented 1 month ago

Currently the husky pre-commit.mjs executes git add .

A slight improvement to this would be modify this to git add component-models.json component-definition.json component-filters.json to limit the add to the files which are altered by the precommit hook to avoid accidentally including unrelated changes in the commit.

buuhuu commented 1 month ago

Good catch @josephrignanese, merged, thanks.