search

adobe-type-tools / afdko

Adobe Font Development Kit for OpenType
https://adobe-type-tools.github.io/afdko/
Other
1.06k stars 167 forks source link

[makeotf] hit a crash in otl.c: freeCoverage #1110

Open yarmola opened 4 years ago

yarmola commented 4 years ago

I am still investigating this issue, but I hit a crash in this function:

https://github.com/adobe-type-tools/afdko/blob/df31d5e7f43decf90c3970f445280d9444e5d931/c/makeotf/makeotf_lib/source/hotconv/otl.c#L601-L613

rec->tbl here is nullptr.

FEA file hit "offset overflow" error and after freeing data, I hit the problem. Simple if (!rec->tbl) return; in the beginning fixes it, but I will try to find more info.

(you also may want to replace "formated" with "formatted")

josh-hadley commented 4 years ago

@yarmola thanks. As before: if you're able to share, an example feature file that triggers this would be really useful.

yarmola commented 4 years ago

Still the same story: I get sample files from FL users and they are all under "automatic" NDA. I'll try to reproduce it, but it correlates with "offset overflow" for ligature lookup.

yarmola commented 4 years ago

"screen sharing" debug session is an option, I can do it by Skype.