search

adobe-type-tools / cffsubr

Standalone CFF subroutinizer based on AFDKO tx
Apache License 2.0
8 stars 8 forks source link

Update AFDKO submodule to latest stable version #18

Closed khaledhosny closed 3 years ago

khaledhosny commented 3 years ago

Update to 3.6.1 and remove the no longer needed workaround for https://github.com/adobe-type-tools/cffsubr/issues/13.

anthrotype commented 3 years ago

I'm not sure about the MSBuild failure, I can look into it tomorrow if you haven't fixed it by then already

josh-hadley commented 3 years ago

I'm not sure about the MSBuild failure, I can look into it tomorrow if you haven't fixed it by then already

Probably needs the microsoft/setup-msbuild action updated to a newer version as the old one uses a deprecated action (add-path). We did this in the main AFDKO repo a while back: https://github.com/adobe-type-tools/afdko/pull/1254, specifically https://github.com/adobe-type-tools/afdko/pull/1254/commits/4ed1cf60e5febde222997362debaae9b7b60eaf4#diff-bc3a78bf1262e6c7b766fd61fa1eb071bbfdda4ca421666a1ea6797861703f50R54

anthrotype commented 3 years ago

thanks Josh, I'll do that