search

adobe-type-tools / otf-making-benchmark

Compare makeotf with fontmake output
SIL Open Font License 1.1
15 stars 3 forks source link

Test new fontTools table packing #1

Open miguelsousa opened 6 years ago

miguelsousa commented 6 years ago

Branch: https://github.com/fonttools/fonttools/tree/99proof Issue: https://github.com/fonttools/fonttools/issues/1105#issuecomment-351194784

miguelsousa commented 6 years ago

Added Source Serif. Its kerning does not overflow. Building it with fonttools 99proof branch and with v3.22.0 produces the same results.

Trying to build the Sans (whose kerning overflows) with the 99proof branch fails. This is expected because overflow resolution isn't implemented yet.

behdad commented 6 years ago

How can I test this again?

miguelsousa commented 6 years ago

@behdad run any of the shell scripts

miguelsousa commented 6 years ago

There are 4 of them buildSans-fontmake.sh buildSans-makeotf.sh buildSerif-fontmake.sh buildSerif-makeotf.sh

behdad commented 6 years ago

Thanks.

Ok, seems like this is not a purely packing issue. If I ttx the makeotf output and compile it back, fonttools master works fine. This suggests that there's a problem with how feaLib is building tables that triggers the much larger size. Still, I'll optimize the packing; we can figure that out separately. Probably worth filing an issue about it, because this looks distinct from https://github.com/fonttools/fonttools/issues/1105 which is purely suboptimal packing.

behdad commented 5 years ago

Can you reopen this? I like to figure out some time.

miguelsousa commented 5 years ago

Done