adobe / NLP-Cube

Natural Language Processing Pipeline - Sentence Splitting, Tokenization, Lemmatization, Part-of-speech Tagging and Dependency Parsing
http://opensource.adobe.com/NLP-Cube/index.html
Apache License 2.0
550 stars 93 forks source link

Russian model of nlpcube 0.3.1.0 does not work #129

Closed KoichiYasuoka closed 3 years ago

KoichiYasuoka commented 3 years ago

Describe the bug dependency parser of Russian model does not work

To Reproduce

>>> from cube.api import Cube
>>> nlp=Cube()
>>> nlp.load("ru")
>>> doc=nlp("Москва слезам не верила, а верила любви.")
>>> print(doc)
1   Москва  москва  <PAD>   VBNL    Animacy=Anim|Aspect=Perf|Case=Ins|Number=Plur|Tense=Past|VerbForm=Part|Voice=Pass   0   <PAD>   _   _
2   слезам  слез    PROPN   PRON    Aspect=Imp|Case=Acc|Gender=Fem|Number=Sing|Tense=Pres|VerbForm=Part|Voice=Pass  1   <PAD>   _   _
3   не  не  DET JJR Animacy=Inan|Case=Acc|Gender=Fem    1   <PAD>   _   _
4   верила  верилый DET :   Aspect=Imp|Case=Dat|Gender=Neut|Number=Sing|Tense=Past|VerbForm=Part|Voice=Pass 1   <PAD>   _   _
5   ,   ,   PROPN   PRON    Animacy=Inan|Aspect=Imp|Case=Nom|Gender=Fem|Number=Sing|Tense=Past|VerbForm=Part|Voice=Act  1   <PAD>   _   _
6   а   а   DET JJR Animacy=Inan|Aspect=Perf|Case=Ins|Gender=Neut|Number=Sing|Tense=Past|VerbForm=Part|Voice=Pass   1   <PAD>   _   _
7   верила  верилый DET :   Aspect=Perf|Case=Nom|Number=Plur|Tense=Past|VerbForm=Part|Voice=Mid 1   <PAD>   _   _
8   любви   Любовь  PROPN   PRON    Animacy=Inan|Aspect=Imp|Case=Nom|Gender=Fem|Number=Sing|Tense=Past|VerbForm=Part|Voice=Act  1   <PAD>   _   _
9   .   .   PROPN   PRON    Aspect=Imp|Case=Acc|Gender=Fem|Number=Sing|Tense=Pres|VerbForm=Part|Voice=Pass  1   <PAD>   _   _

Expected behavior deprel should not be <PAD>

tiberiu44 commented 3 years ago

Thank you for noticing this. I will update this model as well.

tiberiu44 commented 3 years ago

This is now fixed with the latest model update:

In [4]: cube('Москва слезам не верила, а верила любви.')                                                                                                              
Out[4]: 
1   Москва  Москва  PROPN   _   Animacy=Inan|Case=Nom|Gender=Fem|Number=Sing    4   nsubj   _   _
2   слезам  слеза   NOUN    _   Animacy=Inan|Case=Dat|Gender=Fem|Number=Plur    4   iobj    _   _
3   не  не  PART    _   _   4   advmod  _   _
4   верила  верить  VERB    _   Aspect=Imp|Gender=Fem|Mood=Ind|Number=Sing|Tense=Past|VerbForm=Fin|Voice=Act    0   root    _   _
5   ,   ,   PUNCT   _   _   7   punct   _   _
6   а   а   CCONJ   _   _   7   cc  _   _
7   верила  верить  VERB    _   Aspect=Imp|Gender=Fem|Mood=Ind|Number=Sing|Tense=Past|VerbForm=Fin|Voice=Act    4   conj    _   _
8   любви   любовь  NOUN    _   Animacy=Inan|Case=Acc|Gender=Fem|Number=Plur    7   obl _   _
9   .   .   PUNCT   _   _   4   punct   _   _
KoichiYasuoka commented 3 years ago

I've just confirmed that the updated Russian model works well. Thank you @tiberiu44 and now I close this issue.