adobe / acc-js-sdk

A JavaScript SDK for Adobe Campaign Classic
Apache License 2.0
21 stars 20 forks source link

Add support for file download #106

Closed kumarvishal closed 1 month ago

kumarvishal commented 2 months ago

Description

We've an API available in backed named downloadFile.jsp which provides us a way to download the file from instance server.

This API is complmentry of uploadFile.jsp which we're using in ACC WebUI to upload files for various puposes. These files go to 'upload' folder on the instance's home folder and we can download only those file which are available in this folder.

We already have a fileUploader.upload available in this SDK, adding support for fileUploader.download in this PR.

It is important to keep this under fileUploader because this is not a generic utility and can download files only from upload folder i.e. can only download the files which are uploaded using fileUploader.upload.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

kumarvishal commented 1 month ago

Hi Vishal, this looks good. There are a few minor details, could you please make the changes?

Hi Alex

Thanks for review, I’ve update the PR #106 with requested changes.

Please re-review.