adobe / acc-js-sdk

A JavaScript SDK for Adobe Campaign Classic
Apache License 2.0
21 stars 20 forks source link

Fix encoding of the soapRouter URL parameters #64

Closed mkiki closed 1 year ago

mkiki commented 1 year ago

Description

For troubleshooting purpose, the SDK is adding a query parameter with the API call URN (schema and method) to the soap router end point. This was not correctly URL encoded, which can cause problems in some cases. Now the query parameter is properly encoded.

Normal SOAP URL: https://myinstance.com/nl/jsp.soapRouter.jsp Previous URL (not properly encoded): https://myinstance.com/nl/jsp.soapRouter.jsp?xtk:session:Empty New URL (properly encoded): https://myinstance.com/nl/jsp.soapRouter.jsp?soapAction=xtk%3Asession%23Empty

The new encoding (potentially breaking change) is a query parameter named soapAction which contains the encorde URN of the SOAP call.

How Has This Been Tested?

Unit tests Instance which was causing problems

Types of changes

Checklist: