adobe / acc-js-sdk

A JavaScript SDK for Adobe Campaign Classic
Apache License 2.0
21 stars 20 forks source link

fix bug in uploadAemAsset when used through browser #93

Closed pk28yadav closed 11 months ago

pk28yadav commented 11 months ago

Description

The change done in https://github.com/adobe/acc-js-sdk/pull/91 didn't work correctly when sdk is used inside browser. Noticed that we have two different implementations of transport layer - axios(node) & fetch(browser). I didn't knew that earlier & had only tested with a nodejs app. Two issues -

Related Issue

ttps://github.com/adobe/acc-js-sdk/pull/91

Motivation and Context

How Has This Been Tested?

same as linked PR

Screenshots (if appropriate):

Types of changes

Checklist:

pk28yadav commented 11 months ago

@mkiki , sorry for inconvenience, but my last code failed on browser. Please add review.

mkiki commented 11 months ago

Will fix the transport function to have a consistent behavior in future PR