Marketo Forms Integration - Backend Code

adobe / adobe-dx

A toolkit for AEM to help build exceptional digital experiences.

Apache License 2.0

35 stars 33 forks source link

Marketo Forms Integration - Backend Code #100

Closed janaki-r-bhagwath closed 4 years ago

janaki-r-bhagwath commented 4 years ago

Encryption servlet added in admin to support encryption
Content introduced and has marketo datasource and services enabled only in author
Generic CloudConfigReader introduced but currently restricted to marketo
Marketo Components (base, footer) models introduced - FooterModel has hardcoded list for now, to be integrated with component finder later
Osgi config for content placed inside content
Sample working Marketo Component and Footer introduced so FE can integrate easily
Unit Tests Pending

Resolves: Marketo BE Code

janaki-r-bhagwath commented 4 years ago

@npeltier , Have addressed the review comments, except for the ones that I have provided reasons for the code.

npeltier commented 4 years ago

Thanks @janaki-r-bhagwath !

note: Not sure how you added authors and all in the commit message, "fixed" that by adding you as author and chris and myself as reviewers. This would be a cool addendum to a commit message format i desperatly try to talk about there https://github.com/orgs/adobe/teams/adobe-dx-devs/discussions/3

janaki-r-bhagwath commented 4 years ago

Not sure how you added authors and all in the commit message, "fixed" that by adding you as > author and chris and myself as reviewers.

I have no idea n how that happened.. Likely the second commit had something.