adobe / adobe-dx

A toolkit for AEM to help build exceptional digital experiences.
Apache License 2.0
35 stars 33 forks source link

Marketo Form Profile Service #187

Open yesil opened 3 years ago

yesil commented 3 years ago

This is about enhancing Marketo Form component with:

The form component dialog options should appear only if the Profile URL is defined in the cloud configuration

yesil commented 3 years ago

I would like to use a render condition to display the Profile Service specific options in the form dialog only if the Profile URL is defined in the Marketo cloud config.

The question is if I extend com.adobe.dx.admin.rendercondition.AbstractRenderCondition do I need to put my marketo specific render condition in the admin module in which case I cannot use com.adobe.dx.content.marketo.models.internal.MarketoConfBasicInfo? to map the marketo config.

Alternatively I can add a CloudConfigPropertyRenderCondition in the admin module which will check if a given property is defined in a given cloud config?

Which one is preferable?

npeltier commented 3 years ago

@yesil definitely the later, as it will not break the modularisation.