adobe / adobe-dx

A toolkit for AEM to help build exceptional digital experiences.
Apache License 2.0
35 stars 33 forks source link

allowing the pipe shell script to accept arguments with spaces #193

Closed luckyluke-adobe closed 2 years ago

luckyluke-adobe commented 2 years ago

Description

This PR contains a change in the pipe shell script, which allows to have argument values with spaces and other statements.

Motivation and Context

The change is motivated due to the recent change of the replace pipe, which accepts a lot more freedom. But the change would only allow running the pipe with direct curl call or other triggers.

The PR allows to call the following command:

./pipe -s http://localhost:4502 -b "root=/content/experience-fragments,type=cq:PageContent,criteria='@cq:template="/conf/myApp/settings/wcm/templates/experience-fragment-template" and @sling:resourceType="oldApp/components/structure/xfpage"',property=sling:resourceType,newValue=newApp/components/structure/xfpage"

How Has This Been Tested?

This has currently been tested with a debug option in the pipe shell script. It also has been tested altering the pipe script to use -F instead of -d option. see GH-195

Screenshots (if appropriate):

Types of changes

Checklist:

npeltier commented 2 years ago

thx @luckyluke-adobe for the contribution!