adobe / adobe.github.com

Adobe central hub for open source
https://opensource.adobe.com
MIT License
1.42k stars 340 forks source link

fixed position of show more/less button #138

Closed charan-mudiraj closed 8 months ago

charan-mudiraj commented 10 months ago

Description

The position property "Show More..." / "Show Less..." button was changing to "fixed" when "Show More..." button is clicked(when the repos list is expanded). This behaviour was implemented by using "showMore" boolean variable. In the fix, i've removed the usages of the "showMore" variable and permanently assigned the position as "absolute".

Related Issue

Fixes #51

Motivation and Context

The Button was overlapping with the content on its back. This fix resolves that issue by fixing the button at the bottom of the list irrespective of the state of "repos" list (expanded/collapsed).

How Has This Been Tested?

I've tested this fix by running it on my local environment. This change does not affecting any other areas of the code(since the usage of "showMore" boolean was limited to the button.

Screenshots (if appropriate):

https://github.com/adobe/adobe.github.com/assets/100061869/70d1934e-b5ea-4303-9e11-fc236bac19ba

Types of changes

Checklist:

charan-mudiraj commented 10 months ago

i'm unable to resolve the CLI Signing issue. i've already signed but still getting the issue. Please review my pull request.