[feature] Support for recent Angular Versions

cwuerzlhuber commented 3 years ago

Is your feature request related to a problem? Please describe. Currently the aem-angular-editable-components library is supporting and using Angular Version 9, so we are currently already 4 versions behind to current version 13. Also the package does not run/support Ivy by default, which is the standard nowadays. So we would like the be able to update to at least version 12 and be able to run with Ivy enabled without any issues, and no npm dependency version warning.

Describe the solution you'd like

To support multiple versions of Angular on consumer side, there needs to a concept like a compatibility table for different versions like for example ng-bootstrap does (https://ng-bootstrap.github.io/#/getting-started#dependencies)
Major Angular version should be updated 1 by 1 and versions published according to the compatibility concept
Ivy should be supported, since this is the default view engine in all Angular versions starting already with Angular 9

Describe alternatives you've considered

Force update Angular versions in consumer app, but this will create warnings due to incompatible peer dependencies.

Additional context

ChazUK commented 2 years ago

This really needs to get updated to be compatible with latest versions of Angular

kk7970704 commented 1 year ago

Is anyone using this with Angular 13? We tried to upgrade to 13, but as mentioned above received 'incompatible peer dependencies' warnings. After deploying to our AEM instance, we just get a blank page. No errors that we could find in the logs.

lutel commented 1 year ago

It has also become a critical issue for us. We are stuck with unsupported Angular version due to incompatibility. Is there any chance that Adobe will support and update it so that at least 13 (LTS version, with security updates, but preferably 14 or 15 as 13 LTS will end in May) is supported?

fdambrosio commented 1 year ago

Hi, do you think that it's fixed with the latest 2.0.0 version of this project? It officially support Angular 13 reading the release note

v2.0.0 https://github.com/adobe/aem-angular-editable-components/commit/d797aaded60c2813fec833463d1dcfe7f29507ab

Eldrisch commented 1 year ago

Hello, the issue is almost fixed I would say. There is one problem with recent changes made in aem-model-provider.component.ts. Adding async/await to ngOnInit makes components load really slow which causes long loading time (around 15s). Removing async await and changing return type from Promise to void again resolves this issue.

If you could please remove those changes or propose different solution.

koolkav1 commented 3 months ago

I refactored the packages, available here: https://www.npmjs.com/package/@kav-khalsa/aem-angular-editable-components and https://www.npmjs.com/package/@kav-khalsa/adobe-aem-spa-model-manager, using standalone, on Angular 18. The issue is that the packages instantiate the services/models in the packages which slows it down and is not compatible with Angular version 16 and above. So I have refactored everything and used Angular services so it operates a whole lot faster. @Eldrisch , please take a look and let me know how you get on.

dMontyx commented 1 month ago

Hello, I want to confirm the same problem found by @Eldrisch when trying to upgrade one of our enterprise projects from Angular v15 to v17. This bug does not allow us to update to Angular v17, so it would be really important for us to get it fixed as soon as possible.

We have tested what Eldrish indicated and I confirm that, by replacing that portion of code, the library works correctly.

Thanks a lot

adobe / aem-angular-editable-components

[feature] Support for recent Angular Versions #65