search

adobe / aem-boilerplate

Use this repository template for new AEM projects.
https://main--aem-boilerplate--adobe.hlx.page
Apache License 2.0
111 stars 284 forks source link

chore: unify font #362

Open fkakatie opened 1 month ago

fkakatie commented 1 month ago

⚠️ potentially controversial: added a new font for the heading-font-family variable. boilerplate uses Roboto, which is already a departure from s2. most projects have multiple fonts, so including an example on how to properly configure those might be useful.

Test URLs:

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [afee66e](https://github.com/adobe/aem-boilerplate/commit/afee66e2eacb9aa19f369c41641fd6ecd8ca651e) :white_check_mark: (latest) * [7a260c0](https://github.com/adobe/aem-boilerplate/commit/7a260c09ee39a731a74962a6ae9dcf9d23d6c5f9) :white_check_mark: * [4be1344](https://github.com/adobe/aem-boilerplate/commit/4be13442b03ba663a6173e11575986b783e59835) :white_check_mark: * [6b99daa](https://github.com/adobe/aem-boilerplate/commit/6b99daa7e10e7a9fb6f9da168230e09f3ebb817c) :white_check_mark:
aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
rofe commented 1 month ago

Is S2 compliance really a requirement for the boilerplate?

fkakatie commented 1 month ago

Is S2 compliance really a requirement for the boilerplate?

Not at all. I'm only pulling values from it in an attempt to set some sort of visual consistency across boilerplate > block collection.