adobe / aem-boilerplate

Use this repository template for new AEM projects.
https://main--aem-boilerplate--adobe.hlx.page
Apache License 2.0
111 stars 284 forks source link

chore: unify color #363

Open fkakatie opened 1 month ago

fkakatie commented 1 month ago

update color (background and text, including links) to align with s2 design

Test URLs:

Before: https://main--aem-boilerplate--adobe.hlx.live/ After: https://unify-color--aem-boilerplate--adobe.hlx.live/

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [51acbed](https://github.com/adobe/aem-boilerplate/commit/51acbedbbfd139ef06b9be289bc486b5fcbf51d9) :white_check_mark: (latest) * [5722538](https://github.com/adobe/aem-boilerplate/commit/5722538b44a45f073de670da3837aeb5fc32abff) :white_check_mark: * [d105bef](https://github.com/adobe/aem-boilerplate/commit/d105bef93d12b4db7f80d699a1d9efa2f1d1416c) :white_check_mark: * [7b3ab37](https://github.com/adobe/aem-boilerplate/commit/7b3ab373baca5a00a52d8d0e6c3862b3e5688164) :white_check_mark: * [6b99daa](https://github.com/adobe/aem-boilerplate/commit/6b99daa7e10e7a9fb6f9da168230e09f3ebb817c) :x:
aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
rofe commented 1 month ago

Is S2 compliance really a requirement for the boilerplate?

fkakatie commented 1 month ago

Is S2 compliance really a requirement for the boilerplate?

Not at all. I'm only pulling values from it in an attempt to set some sort of visual consistency across boilerplate > block collection.

rofe commented 1 month ago

I think having 3 x 100 in PSI out of the box should be considered a higher priority than visual consistency.

fkakatie commented 1 month ago
Screenshot 2024-06-06 at 10 44 27 AM

What am I missing here? Discrepancy between aem-code-sync report and PSI report: https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Funify-color--aem-boilerplate--adobe.hlx.live%2F

rofe commented 1 month ago

What am I missing here? Discrepancy between aem-code-sync report and PSI report:

I clicked re-run PSI check, now it's showing the same.