adobe / aem-cif-guides-venia

AEM CIF Venia Project
Apache License 2.0
39 stars 33 forks source link

CIF-2720: configure recommended site structure #294

Closed buuhuu closed 2 years ago

buuhuu commented 2 years ago

Description

With https://github.com/adobe/aem-core-cif-components/pull/922 an certain site structure is expected to support multiple catalog pages. This change applies the structure to Venia as example.

In general it means:

Related Issue

CIF-2720

Motivation and Context

A completely unstructured site structure does not make much sense in many cases, for example nesting a landing page in another landing page, or nesting a specific category page below a product page.

The actual structure is not and will not be enforced by the CIF Core Components, some features however depend on a certain structure and so the recommended nesting of page types has been implemented to document this as best practice.

How Has This Been Tested?

Locally (make sure to delete /content/venia and /conf/venia first)

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #294 (7c085f5) into dev (ba68a99) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #294   +/-   ##
=========================================
  Coverage     86.66%   86.66%           
  Complexity       20       20           
=========================================
  Files             1        1           
  Lines            30       30           
  Branches          4        4           
=========================================
  Hits             26       26           
  Misses            2        2           
  Partials          2        2           
Flag Coverage Δ
unittests 86.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba68a99...7c085f5. Read the comment docs.

LSantha commented 2 years ago

+1 Long overdue!