adobe / aem-cif-guides-venia

AEM CIF Venia Project
Apache License 2.0
39 stars 33 forks source link

CIF-2827: Add produclist XF example #299

Closed laurentiumagureanu closed 2 years ago

laurentiumagureanu commented 2 years ago

Description

Added example usage of XF placeholder in productlist

Related Issue

CIF-2827

Motivation and Context

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #299 (8e2d819) into dev (2ad1af4) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #299   +/-   ##
=========================================
  Coverage     77.14%   77.14%           
  Complexity       21       21           
=========================================
  Files             1        1           
  Lines            35       35           
  Branches          4        4           
=========================================
  Hits             27       27           
  Misses            6        6           
  Partials          2        2           
Flag Coverage Δ
unittests 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ad1af4...8e2d819. Read the comment docs.

buuhuu commented 2 years ago

This change is missing the policy configuration of the styles for the XF in the product list. When editing the product list this causes the css class to be cleared and the XF appears at the bottom of the list.