adobe / aem-cif-guides-venia

AEM CIF Venia Project
Apache License 2.0
36 stars 32 forks source link

CIF-2865: remove duplicated datalayer clientlib #301

Closed buuhuu closed 2 years ago

buuhuu commented 2 years ago

Description

With embedding the datalayer clientlib we duplicate the javascript on the page, causing all cmp:clicks to be tracked twice.

This change removes the embed. Now the datalayer clientlib is only loaded async by the page v3 component we use.

Related Issue

CIF-2865

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #301 (4ebfb44) into dev (b56d17f) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #301   +/-   ##
=========================================
  Coverage     87.09%   87.09%           
  Complexity       21       21           
=========================================
  Files             1        1           
  Lines            31       31           
  Branches          4        4           
=========================================
  Hits             27       27           
  Misses            2        2           
  Partials          2        2           
Flag Coverage Δ
unittests 87.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b56d17f...4ebfb44. Read the comment docs.