adobe / aem-cif-guides-venia

AEM CIF Venia Project
Apache License 2.0
39 stars 33 forks source link

SITES-22611: Adds filters for commerce api issues #328

Closed alwinjoseph02 closed 4 months ago

alwinjoseph02 commented 5 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 70.23810% with 25 lines in your changes missing coverage. Please review.

Project coverage is 77.84%. Comparing base (962a249) to head (d4d3465).

Files Patch % Lines
...dels/commerce/servlets/CatalogPageErrorFilter.java 69.38% 5 Missing and 10 partials :warning:
...ommerce/services/CommerceComponentModelFinder.java 71.42% 8 Missing and 2 partials :warning:

:exclamation: There is a different number of reports uploaded between BASE (962a249) and HEAD (d4d3465). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (962a249) | HEAD (d4d3465) | |------|------|------| |unittests|2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #328 +/- ## ============================================ - Coverage 85.50% 77.84% -7.67% - Complexity 42 72 +30 ============================================ Files 2 4 +2 Lines 69 167 +98 Branches 7 31 +24 ============================================ + Hits 59 130 +71 - Misses 6 20 +14 - Partials 4 17 +13 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-cif-guides-venia/pull/328/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/adobe/aem-cif-guides-venia/pull/328/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `77.84% <70.23%> (-7.67%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.