Fix for Sub-variant selection in "Productreference " data type

Satish-Pothabathula commented 3 weeks ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.62%. Comparing base (7a2d996) to head (c6cbb5b).

Files with missing lines	Patch %	Lines
...a/core/models/commerce/MyProductReferenceImpl.java	0.00%	12 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (7a2d996) and HEAD (c6cbb5b). Click for more details.

HEAD has 8 uploads less than BASE
| Flag | BASE (7a2d996) | HEAD (c6cbb5b) | |------|------|------| |unittests|9|1|

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #333 +/- ## ============================================ - Coverage 77.84% 72.62% -5.22% Complexity 72 72 ============================================ Files 4 5 +1 Lines 167 179 +12 Branches 31 31 ============================================ Hits 130 130 - Misses 20 32 +12 Partials 17 17 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-cif-guides-venia/pull/333/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/adobe/aem-cif-guides-venia/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `72.62% <0.00%> (-5.22%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LSantha commented 2 weeks ago

@Satish-Pothabathula , please close this PR and open a new PR for the dev branch. We're doing the development work on the dev branch and sync dev to main only when we are preparing a new release.

Satish-Pothabathula commented 2 weeks ago

raising new PR for dev branch so closing these PR

adobe / aem-cif-guides-venia